Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy signature help interaction code. #76495

Merged
merged 19 commits into from
Dec 19, 2024
Merged

Remove legacy signature help interaction code. #76495

merged 19 commits into from
Dec 19, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 18, 2024 •
edited
Loading

The platform has taken over handling the interaction of sighelp and completion. So the code we have in roslyn to manage this is no longer necessary.

I have also verified the same scenarios manually work. For example:

  1. when both sig help and completion are up, completion should be processing the handling or up/down.
  2. if both are up an completion is disabled using 'esc', then sig help should process up/down keys
  3. if there is only one sig help item, and up/down is hit, it should be dismissed and the user should navigate.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 18, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title remove type with no effect Remove legacy signature help interaction code. Dec 18, 2024
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski ptal.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review December 18, 2024 18:03
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 18, 2024 18:03
CyrusNajmabadi
CyrusNajmabadi commented Dec 18, 2024
View reviewed changes
src/EditorFeatures/Core/IntelliSense/ModelComputation.cs
{
ThreadingContext.ThrowIfNotOnUIThread();

var model = ModelTask.WaitAndGetResult(CancellationToken.None);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got rid of another blocking wait, which was the initial reason i was in this space. but i then discovered just how useless all this code is to begin with...

@CyrusNajmabadi
Copy link
Member Author

@dotnet/roslyn-ide @jasonmalinowski ptal.

@CyrusNajmabadi CyrusNajmabadi merged commit c49efbd into dotnet:main Dec 19, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the sigHelpCompletion branch December 19, 2024 00:09
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@jasonmalinowski jasonmalinowski Awaiting requested review from jasonmalinowski

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @JoeRobich